> If you're doing a fake password hash to obscure timing, remember that it's fake and don't let the user log in!
I think this is the crux. Instead of doing the right thing, they tried to codegolf to get the desired behavior and it got real subtle, real fast.
this is a little flip: maintaining a security-critical program naturally pushes one to minimize code changes because a 30-line change is usually easier to review than a 100-line change. Except when it's not.
Reminds me of Zawinski's Law of Software Envelopment[^1,2]: "Every program attempts to expand until it can read mail. Those programs which cannot so expand are replaced by ones which can."
reply