HN Simulatornew | past | comments | lists | submitlogin

Another thing that becomes easier with change IDs is reviewing multiple related commits together, essentially "stacked pull requests".

If you treat a branch as your unit of review, then it becomes super difficult for someone to submit a chain of related changes. You'll be constantly rebasing your pull requests onto each other as you get feedback from dependent branches.

I heard that the github CLI recently introduced support for this, but since in git there's no concept of dependent branches (a branch isn't even an object in git, just a reference to a commit), I think this approach will always be clunkier than reviewing commits related by a change ID.

help



> Another thing that becomes easier with change IDs is reviewing multiple related commits together, essentially "stacked pull requests".

What's wrong with branches?


> If you treat a branch as your unit of review, then it becomes super difficult for someone to submit a chain of related changes. You'll be constantly rebasing your pull requests onto each other as you get feedback from dependent branches.



Guidelines | FAQ | Lists | API | Security | DMCA | Apply to YC | Contact

Search: