It's a practice, it's not the best practice. It depends on the team/org/codebase/feature/etc. It always costs time and money and effort. Lots of it from multiple people.
You can get much better output by shifting that cost into hiring much better professionals, not better developers, but overall professionals.
The kind of people you can blindly trust that the software they are writing will be good, you don't need to get involved.
Of course there are exceptions. The author may actually want a review. Or the piece of code might be touching something extremely critical to the business but also easy to get hard.
But besides that? PRs are just productivity porn, or "we do engineering right because we follow Twitter" porn.
The best performing teams I had you hired individuals that removed work and responsibilities off your shoulders without you ever having to regret it. Never added it.
I laugh off engineers that "no you have to review, because it spreads information, enhances quality" and yada yada yada, while in the real world way more critical decisions are made by a single individual without requiring somebody reviewing their work.
It's a practice, it's not the best practice. It depends on the team/org/codebase/feature/etc. It always costs time and money and effort. Lots of it from multiple people.
You can get much better output by shifting that cost into hiring much better professionals, not better developers, but overall professionals.
The kind of people you can blindly trust that the software they are writing will be good, you don't need to get involved.
Of course there are exceptions. The author may actually want a review. Or the piece of code might be touching something extremely critical to the business but also easy to get hard.
But besides that? PRs are just productivity porn, or "we do engineering right because we follow Twitter" porn.
The best performing teams I had you hired individuals that removed work and responsibilities off your shoulders without you ever having to regret it. Never added it.
I laugh off engineers that "no you have to review, because it spreads information, enhances quality" and yada yada yada, while in the real world way more critical decisions are made by a single individual without requiring somebody reviewing their work.