I've kept all photos on iCloud since decades; there's too many to move elsewhere and keep updated, but the local copy on my Mac is regularly backed up to a Time Machine disk.